Extend pull lambda out for conditional expression#21344
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Nov 16, 2023
Merged
Extend pull lambda out for conditional expression#21344feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu merged 1 commit intoprestodb:masterfrom
Conversation
96d1e1d to
ac1d27d
Compare
kaikalur
approved these changes
Nov 10, 2023
mlyublena
approved these changes
Nov 10, 2023
ajaygeorge
approved these changes
Nov 16, 2023
Contributor
ajaygeorge
left a comment
There was a problem hiding this comment.
Stamping since it is already reviewed.
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try to extract independent expressions from the conditional expressions.
Motivation and Context
In current code, when the expression is in a conditional expression, we will skip them. For example, for
transform(col1, x -> if(col3 > 2, col2[2], 0)), we will skip and do not extract anything from the lambda expression. We chose this behavior because expressions in conditional expressions may not be executed.However, some part of the conditional will always be evaluated, for example in the above expression
transform(col1, x -> if(col3 > 2, col2[2], 0))we can extractcol3>2out, as it's a condition and will always be evaluated. In this PR, I extend the optimizer to extract these expressions.Impact
Increase the coverage of this optimizer.
Test Plan
Unit test and verifier run test
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.